Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Bind TabContainer::get_tab_idx_at_point() to ClassDB #52047

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

nobuyukinyuu
Copy link
Contributor

@nobuyukinyuu nobuyukinyuu commented Aug 24, 2021

(Note: this is the 3.x-ready branch for #52050.)

As it currently stands, there's no reliable way from the GDScript to determine which tab the mouse is over, which is pretty important for being able to generate a relevant tooltip. This binds the already-used internal method to determine this to ClassDB.

@YeldhamDev
Copy link
Member

This should be pushed towards the master branch, documented, and also binding the Tabs version.

@nobuyukinyuu
Copy link
Contributor Author

nobuyukinyuu commented Aug 24, 2021

Tabs already contains the tab_hover signal which performs this function, and the implementation between the controls is different. I assume documentation PRs go on the godot-docs repo but it likely won't be accepted for a feature that doesn't exist (yet). Luckily, the use case is pretty straightforward.

@nobuyukinyuu nobuyukinyuu changed the title Bind TabContainer::get_tab_idx_at_point() to ClassDB [3.x] Bind TabContainer::get_tab_idx_at_point() to ClassDB Aug 24, 2021
@YeldhamDev
Copy link
Member

Tabs already contains the tab_hover signal which performs this function

Then it would be better to implement tab_hover in TabContainer if possible, so their interfaces remain similar.

I assume documentation PRs go on the godot-docs repo

I meant the internal XML docs. Run --doctool with the compiled binary to create an entry.

The point about the master branch still stands.

@nobuyukinyuu
Copy link
Contributor Author

There is an open proposal regarding the differences in implementation here. Changing the general implementation between the controls is outside of the scope of this PR. I'm only submitting it because I need the feature. (I'll submit a separate PR which can merge with master shortly!)

@nobuyukinyuu
Copy link
Contributor Author

Repo updated with changes to XML, commits squashed and description updated to point to the version that can be merged with master.

@Calinou Calinou added this to the 3.4 milestone Aug 24, 2021
@nobuyukinyuu nobuyukinyuu force-pushed the bind-get-tab-idx-at-point branch 4 times, most recently from 35c1046 to 24482aa Compare August 29, 2021 14:06
@nobuyukinyuu nobuyukinyuu force-pushed the bind-get-tab-idx-at-point branch from 24482aa to 522af5c Compare August 29, 2021 14:11
@groud groud merged commit cf48297 into godotengine:3.x Sep 7, 2021
@groud
Copy link
Member

groud commented Sep 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants