[3.x] Fix duplicated edges in convex hull generator #52046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All edges where accumulated from all faces, which ended up with double the amount in the final mesh data leading to performance issues in godot physics.
lawnjelly
reviewed
Aug 24, 2021
| } | ||
|
|
||
| ConvexHullComputer ch; | ||
| ch.compute(p_points, p_point_count, -1.0, -1.0); | ||
|
|
||
| r_mesh.vertices = ch.vertices; | ||
| int vertex_count = r_mesh.vertices.size(); |
There was a problem hiding this comment.
Could do with a comment here and at the resize at the bottom of the function to explain why this is being done - it is clear in the PR text, but not in the source.
lawnjelly
reviewed
Aug 24, 2021
| if (face.indices.size() >= 3) { | ||
| face.plane = Plane(r_mesh.vertices[face.indices[0]], r_mesh.vertices[face.indices[1]], r_mesh.vertices[face.indices[2]]); | ||
| } else { | ||
| WARN_PRINT("Too few vertices per face."); | ||
| } | ||
| } | ||
|
|
||
| r_mesh.edges.resize(edge_count); | ||
|
|
|
Looks fine to me, I'd just add a couple of comments to explain what is going on in the source because it isn't immediately clear. |
|
Ah, you're of course right. Since this is a half edge data structure, there's a reverse edge for every edge. Rather than going through a set, you can simply pick one of the two as the canonical edge. (E.g. the one where |
|
I made a PR with my approach: #52059 |
|
Closing in favor of #52059. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All edges where accumulated from all faces, which ended up with double the amount in the final mesh data leading to performance issues in godot physics.
Fix #51909 (regression from #48533)
CC @mortarroad if you would like to review
If this fix is ok I'll make a PR on master tomorrow.