Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scaling to the curve editor's handles #50627

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Add scaling to the curve editor's handles #50627

merged 1 commit into from
Jul 20, 2021

Conversation

Atlinx
Copy link
Contributor

@Atlinx Atlinx commented Jul 20, 2021 •
edited by akien-mga
Loading

This fixes #50617

Before the fix the curve editor's handles have no scaling applied on Hi-DPI displays

before_resized

With the fix scaling is applied:

after_resized

@Calinou Calinou added bug cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:editor usability labels Jul 20, 2021
@Calinou Calinou added this to the 4.0 milestone Jul 20, 2021
fire
fire reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo video looks great.

@akien-mga akien-mga merged commit 14c2f5d into godotengine:master Jul 20, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga mentioned this pull request Jul 20, 2021
Closed
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 20, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

@Atlinx Atlinx deleted the fix_50617 branch July 20, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire left review comments

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Curve editor handles too small on Hi-DPI displays
4 participants
@Atlinx @akien-mga @fire @Calinou