[WIP] Fix bug in Plane transform with non-uniform scaling [4.x] #50551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 17, 2021
| Basis b = basis; | ||
| b.invert(); | ||
| b.transpose(); | ||
| Vector3 normal = b.xform(p_plane.normal); |
There was a problem hiding this comment.
I haven't checked the math, but maybe xform_inv is actually a faster shortcut to avoid computing the full inverse transpose matrix?
There was a problem hiding this comment.
It is, but I believe it isn't as robust as doing proper inverse transpose. On a similar note we need to check whether using the xform_inv function on the Vector3 in Transform3D::xform_inv is up to the job.
There was a problem hiding this comment.
Just confirmed, xform_inv doesn't work for Vector3 with non-uniform scales, so I'll change that.
DONE
563abd8 to
d9ac56f
Compare
The previous version gave incorrect normals with non-uniform scaling.
d9ac56f to
b8d2a56
Compare
|
Closing as replaced by #51355. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not up to date
Rather than keep both PRs up to date, I will get some feedback and finalize #50549 first, and then transfer to this version.
Fixes #50548