Move indentation into CodeEdit #49665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bda034 to
bd317e0
Compare
bd317e0 to
1a0cfc2
Compare
bruvzg
approved these changes
Jun 21, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #31739
Builds on top of #49238
The main aim of this PR is abstracting out indentation into CodeEdit. It's now entirely exposed to the API.
As part of the refactor
backspace_at_cursorhas becomebackspace. It has been exposed and made overridable. This will be the way forward for other such actions like cut, copy and paste.Indent size in
TextEditis now called tab size as it no longer relates to spaces.A couple extra utility methods have also be made pubic for use.
Will start to move more functionality in, such as indent type conversion that currently sits within
code_editorwhen theTextEditsplit is complete.