Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to reorder array elements from the inspector #47538

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Add the ability to reorder array elements from the inspector #47538

merged 1 commit into from
Jul 15, 2021

Conversation

AaronRecord
Copy link
Contributor

@AaronRecord AaronRecord commented Apr 1, 2021 •
edited
Loading

Demo video:

2021-04-01_18-28-16.mp4

You click and drag to move elements up or down
Supports dragging between different pages.

Resolves godotengine/godot-proposals#23,
Tested on 3.x (laptop doesn't support vulkan so I can't personally test on 4.0)

If it'd be helpful, I'm willing to open a separate PR for 3.x

@AaronRecord AaronRecord requested a review from a team as a code owner April 1, 2021 03:20
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch 4 times, most recently from 08568f4 to 42519c3 Compare April 1, 2021 03:48
@fire
Copy link
Member

fire commented Apr 1, 2021

This is a great idea. Need to test it when I have time.

@Calinou Calinou added this to the 4.0 milestone Apr 1, 2021
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch 3 times, most recently from 6be21ca to 0acc6ec Compare April 1, 2021 15:24
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch 2 times, most recently from dbd5bf5 to 7369f13 Compare April 1, 2021 16:16
@AaronRecord AaronRecord mentioned this pull request Apr 26, 2021
Open
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch 5 times, most recently from 014350d to abdfe22 Compare May 15, 2021 02:18
@AaronRecord AaronRecord mentioned this pull request May 16, 2021
Merged
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch from abdfe22 to 0840770 Compare June 1, 2021 20:54
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch 2 times, most recently from 89e3892 to 6093211 Compare July 11, 2021 21:58
@AaronRecord AaronRecord force-pushed the inspector-reorder-array-4.0 branch from 6093211 to ec67266 Compare July 11, 2021 22:09
@AaronRecord
Copy link
Contributor Author

@fire Have you gotten around to test it yet? 😃

fire
fire approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks good.

I used the built editor and it seems to work on an array.

Did a timelimited review of the code.

@akien-mga akien-mga merged commit 6ddaebc into godotengine:master Jul 15, 2021
@akien-mga
Copy link
Member

Thanks!

@AaronRecord AaronRecord deleted the inspector-reorder-array-4.0 branch July 15, 2021 15:28
@AaronRecord
Copy link
Contributor Author

This should be able to be pretty easily cherry-picked, I don't think it'll require a separate PR.

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 15, 2021
@akien-mga
Copy link
Member

This should be able to be pretty easily cherry-picked, I don't think it'll require a separate PR.

There's a fair amount of conflicts, a PR would be useful.

@AaronRecord
Copy link
Contributor Author

@akien-mga Sorry about that, I figured it'd be fine since I originally developed it on the 3.x branch and forward ported it to 4.0, but I've been meaning to double check.

@AaronRecord AaronRecord mentioned this pull request Jul 20, 2021
Merged
@YeldhamDev YeldhamDev removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 20, 2021
@kleonc kleonc mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Ability to change order of elements in export (Array)
5 participants
@AaronRecord @fire @akien-mga @Calinou @YeldhamDev