Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature tag casing in the Windows pen tablet project setting name #47255

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix feature tag casing in the Windows pen tablet project setting name #47255

merged 1 commit into from
Mar 22, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 22, 2021 •
edited
Loading

Feature tags are case-sensitive.

Note: We may want to check whether it's a better idea to make all feature tags lowercase for 4.0, and merge this change only in the 3.x branch.

@Calinou Calinou requested review from a team as code owners March 22, 2021 12:58
@Calinou Calinou mentioned this pull request Mar 22, 2021
Closed
@Calinou Calinou added this to the 4.0 milestone Mar 22, 2021
@Calinou Calinou mentioned this pull request Mar 22, 2021
Open
@Calinou Calinou force-pushed the fix-windows-tablet-setting-name branch from d5126c9 to 6c9259f Compare March 22, 2021 13:18
@akien-mga akien-mga merged commit 725552a into godotengine:master Mar 22, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

The bug doesn't affect 3.x, so doesn't need a cherry-pick.

@Calinou Calinou deleted the fix-windows-tablet-setting-name branch March 31, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @bruvzg