Fixed EditorPropertyText change signal emission. #44326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though I haven't tested this PR, I think this will likely fix #43238, so would be good to cherry-pick this to 3.2 as well if that's the case! |
|
I did this pr to solve that problem, on my local branch. Glad to see there was already an open issues. |
akien-mga
approved these changes
Dec 19, 2020
|
Thanks! |
|
|
|
Done with 6583ac3. |
pouleyKetchoupp
added a commit
to nekomatata/godot
that referenced
this pull request
Jan 7, 2021
Adds a cache to the inspector in order to update only modified properties when the property list changes and keep the previous controls whenever possible. This allows calls to property_list_changed_notify to trigger inspector updates without resetting all properties. Fixes godotengine#43238 (re-applies godotengine#44326, reverted because of regression godotengine#44854) Also fixes change signal emission for multiline string properties (same as godotengine#44326 but for multiline strings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EditorPropertyText is not properly emitting the
emit_changesignal.The signal is emitted with the variable
changing = true. You can see that theif (updating) {statement is already preventing such signal to be executed at all while the user is writing; so the correct variable value forchangingisfalse.Bugsquad edit: Fixes #43238.