Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the expected method calling order in SurfaceTool more explicit #43366

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Make the expected method calling order in SurfaceTool more explicit #43366

merged 1 commit into from
Mar 22, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 6, 2020 •
edited
Loading

I bumped into this today while working on #40106.

@Calinou Calinou requested a review from a team as a code owner November 6, 2020 21:04
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation enhancement labels Nov 6, 2020
@Calinou Calinou added this to the 4.0 milestone Nov 6, 2020
clayjohn
clayjohn requested changes Nov 6, 2020
View reviewed changes
doc/classes/SurfaceTool.xml Outdated Show resolved Hide resolved
doc/classes/SurfaceTool.xml Outdated Show resolved Hide resolved
doc/classes/SurfaceTool.xml Outdated Show resolved Hide resolved
doc/classes/SurfaceTool.xml Outdated Show resolved Hide resolved
@Calinou
Copy link
Member Author

Calinou commented Dec 10, 2020 •
edited
Loading

I rebased this PR against the latest master branch and noticed that most methods I modified in the SurfaceTool class are no longer in the class reference. Why is that?

My diff looks like this now (locally):

doc/classes/SurfaceTool.xml | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--

@akien-mga
Copy link
Member

@reduz renamed add_ methods to set_.

@Calinou Calinou force-pushed the doc-surfacetool-method-order branch from 7ec0b3c to 6648dc5 Compare March 21, 2021 20:37
@akien-mga akien-mga merged commit 0339200 into godotengine:master Mar 22, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 23, 2021
@Calinou Calinou deleted the doc-surfacetool-method-order branch March 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees

@Calinou Calinou

Labels
documentation enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @clayjohn