virtual func return type check implemented #38612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 6, 2020
modules/gdscript/gdscript_parser.cpp
Outdated
Comment on lines
7994
to
7995
| if (!p_function->return_type.has_type) | ||
| p_function->return_type = return_type; |
There was a problem hiding this comment.
This should now use braces around the single-line block.
190c37c to
dbe6628
Compare
|
Now that the new GDScript has been merged in the |
|
I tested and the case is in the second screenshot this PR is properly implemented in will raise an error. When not typing the override though, it doesn't raise an error. I opened #73153 to track it. This PR is abandoned so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: godotengine/godot-proposals#811