Add AtlasTexture support in SpriteFrames Editor #37939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1eb2ec to
ed5cef8
Compare
akien-mga
reviewed
Apr 30, 2020
akien-mga
reviewed
Apr 30, 2020
|
The code looks good, I just suggested some stylistic changes which you can do with |
ed5cef8 to
13770ac
Compare
|
should be fine now, thanks akien-mga! |
akien-mga
approved these changes
May 1, 2020
|
Thanks! |
|
Cherry-picked for 3.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for AtlasTexture in the SpriteFrames Editor for the "Add Frames from a Sprite Sheet" option by honoring the used region if the selected Texture is an AtlasTexture.
This fixes the issue mentioned in comment #33855 (comment)