Custom Skeleton3DEditorPlugin

[fire]

Co-authored-by: Marios Staikopoulos marios@staik.net

Sponsored by IMVU.

Features:

Drag and drop skeleton parentage move with UNDO!

Rest and pose are exposed as transforms with degrees as units. [UPDATED]

Can key transforms into animation tracks.

Handles the other variables that represent a bone.

Ensure all used labels are translatable.

DOES NOT FREEZE THE EDITOR FOR 30 seconds swapping between the skeleton and any other node!!!

Use for testing:

https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/Fox/glTF-Binary/Fox.glb

Bugsquad edit: Fixes #35652.

[AndreaCatania]

Sample model: https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/Fox/glTF-Binary/Fox.glb

[AndreaCatania]

@fire you did a really good job here, and this addition improves a lot the skeleton usability!

However, you can find some little tweaks that you can do to the code in order to improve it.

Another comment that I've is that there are too much hard written numbers that makes the code hard to read. See:

for (int i = 0; i < 12; i++) {

What 12 stands for? In these cases would be nice have something like:

const int spin_slider_count = 12;
for (int i = 0; i < spin_slider_count; i++) {

[fire]

Ready for second review. I didn't feel like figuring the math for iterating this and it's less clear with that math.

	transform_slider[0]->set_value(tform.get_basis()[Vector3::AXIS_X].x);
	transform_slider[1]->set_value(tform.get_basis()[Vector3::AXIS_X].y);
	transform_slider[2]->set_value(tform.get_basis()[Vector3::AXIS_X].z);
	transform_slider[3]->set_value(tform.get_basis()[Vector3::AXIS_Y].x);
	transform_slider[4]->set_value(tform.get_basis()[Vector3::AXIS_Y].y);
	transform_slider[5]->set_value(tform.get_basis()[Vector3::AXIS_Y].z);
	transform_slider[6]->set_value(tform.get_basis()[Vector3::AXIS_Z].x);
	transform_slider[7]->set_value(tform.get_basis()[Vector3::AXIS_Z].y);
	transform_slider[8]->set_value(tform.get_basis()[Vector3::AXIS_Z].z);

[fire]

Noticed that Bone Custom [Pose] is missing.

[fire]

Adding bone custom pose to the inspector.

[AndreaCatania]

I didn't feel like figuring the math for iterating this and it's less clear with that math.

You can use this one:

const int matrix_row_count = 3;
const int matrix_column_count = 3;

for(int c = 0; c < matrix_column_count; c++){
    for(int r = 0; r < matrix_row_count; r++){
        transform_slider[(c*matrix_row_count) + r]->set_value(tform.get_basis()[c][r]);
    }
}

[AndreaCatania]

The code looks better now, once fixed the above code it's good to be merged. However, I'm approving it now. Thanks :)

[fire]

Merged AndreaCatania's suggestion, but currently testing a bug with the matrix step being "1".

[fire]

Updated to master. Waiting on the build.

[JFonS]

The spinners used in the inspector only allow integer values, they should have float values.

I would also get rid of the custom grid of spinners and use the same inspector controls useed in Vector3 and Transform properties, but that could be done on a separate PR.

[fire]

@JFonS I changed the default to spinner->set_step(0.001f);.

Agreed, the matrix changes can be another pr.

[akien-mga]

Thanks a lot!

@fire Would you be able to prepare a PR backporting this for the 3.2 branch? Given the amount of changes, I assume that a simple git cherry-pick might not be trivial nor guaranteed to work as expected. -- There's no hurry though, we might want to wait for some testing in master / further fixes before merging the same changes in 3.2, so it could be for 3.2.3.

[slapin]

Would be nice to have for 3.2 as skeleton editing is currently very hard with 175 bones
as editor crashes with default settings freezing the computer beforehand. Increasing queue size fixes the crash but editing is still not a piece of cake.

[keymastar]

Is it possible to use this on 3.2, and if so, how? I am trying to make a 3d game and it seems impossible if I can't access my rigged models.

[Zireael07]

@slapin @keymastar 3.2 version is being worked on here: #39090 and not merged yet.

[keymastar]

@slapin @keymastar 3.2 version is being worked on here: #39090 and not merged yet.

That's great to hear. Thanks for letting me know.

[slapin]

Thanks! Looking forward to it.

…

On Thu, May 28, 2020 at 5:53 PM keymastar ***@***.***> wrote: @slapin <https://github.com/slapin> @keymastar <https://github.com/keymastar> 3.2 version is being worked on here: #39090 <#39090> and not merged yet. That's great to hear. Thanks for letting me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#36409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABPU5BRDDPL3S4RDVROADRTZ3F3ANCNFSM4KY4OZDQ> .

[akien-mga]

Removing cherrypick:3.2 label as the cherrypicking is done via a separate PR: #39090.

[Sawrr]

I am not seeing the "Create physical skeleton" option anymore after this commit. The menu dropdown at the top seems to be missing. Was this intentional?

[fire]

Is not intentional.

[Sawrr]

@fire commenting out options->hide() seemed to fix it https://github.com/godotengine/godot/blob/master/editor/plugins/skeleton_3d_editor_plugin.cpp#L668

[fire]

@Sawrr Can you make a pull request, should be simple to test.

[Sawrr]

@fire Sure. This is my first PR so let me know if I need to add any additional detail #39543

[giabeni]

I think there is still open issues regarding to the Skeleton 3D Editor.

I am using a model with no more than 150 bones and every time that I make a left/right click in the skeleton node, Godot crashes.

I have already tried using the DAE and the GLTF/GLB exports methods... but the result is the same.

I was hopeful that this new release would fix it but no success :( .

Context and Environment:

MacBook Pro macOS Catalina 10.15.1
Processor 2,3 GHz Dual-Core Intel Core i5
Memory 8GB 2133 MHz LPDDR3
Graphics Intel Iris Plus Graphics 640 1536 MB

Is it a memory issue of my computer or is it a real bug?

Btw, the animations and constraints using the bones works normally. It only crashes when selecting the skeleton node.

Thanks in advance

[Zireael07]

IIRC the 3.2 cherrypick hasn't happened yet, so it's on master only?