Improved search in settings dialogs #33047
Conversation
73f0b78 to
b03f5bb
Compare
| @@ -1595,7 +1595,7 @@ void EditorInspector::update_tree() { | |||
| if (capitalize_paths) | |||
| cat = cat.capitalize(); | |||
|
|
|||
| if (!filter.is_subsequence_ofi(cat) && !filter.is_subsequence_ofi(name)) | |||
| if (!filter.is_subsequence_ofi(cat) && !filter.is_subsequence_ofi(name) && property_prefix.to_lower().find(filter.to_lower()) == -1) | |||
There was a problem hiding this comment.
I wonder why this is needed? The previous code was already checking if the filter is either in the property name or the rest of its path (cat), so here it should have been working fine?
There was a problem hiding this comment.
cat here was always an empty String, probably there's an issue somewhere else?
There was a problem hiding this comment.
Judging by the code, it's not meant to be empty, otherwise there wouldn't be a point in testing it. So yeah, would be worth investigating deeper.
There was a problem hiding this comment.
Seems like when the EditorInspector is used in the engine Inspector cat is correctly set and property_prefix is empty, viceversa when it's used either in the project or editor settings.
Those variable are deduced from the EditorInspector's property list on line 1463 and it has been this way since 005b69cf6e when editor_inspector.h/cpp have been created, so my guess is that it's expected to be like so. Don't know if I'm missing something.
0c998c0 to
969de15
Compare
Settings search used to work only on properties, so if a searchbox text was a substring of a category but not of a property the whole category would be filtered out and no property would be shown. Now the behaviour is changed so that when the searchbox text is a substring of a category all its properties are shown too. The previous behaviour is still present so that in case the searchbox text is both a substring of a category and a property of another category, all properties of the first category are shown and only the property of the second category is shown.
969de15 to
84410f9
Compare
|
Thanks! |
|
Cherry-picked for 3.2.1. |
Settings search used to work only on properties, so if a searchbox text
was a substring of a category but not of a property the whole category
would be filtered out and no property would be shown.
Now the behaviour is changed so that when the searchbox text is a
substring of a category all its properties are shown too.
The previous behaviour is still present so that in case the searchbox
text is both a substring of a category and a property of another
category, all properties of the first category are shown and only the
property of the second category is shown.
Fixes #33005