Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android Launcher Activity #32248

Merged
merged 1 commit into from
Sep 22, 2019
Merged

Fix Android Launcher Activity #32248

merged 1 commit into from
Sep 22, 2019

Conversation

cagdasc
Copy link
Contributor

@cagdasc cagdasc commented Sep 22, 2019

With PR #31919 Android file hierarchy was changed and when you want to run project from editor, game can not start automatically for Android because adb want to start different activity which does not launcher.

@Chaosus Chaosus added this to the 3.2 milestone Sep 22, 2019
@NeoSpark314 NeoSpark314 mentioned this pull request Sep 22, 2019
Closed
@cagdasc
Copy link
Contributor Author

cagdasc commented Sep 22, 2019

@Chaosus reviewer?

m4gr3d
m4gr3d approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix!

@akien-mga akien-mga merged commit 0337282 into godotengine:master Sep 22, 2019
@akien-mga
Copy link
Member

Thanks!

@cagdasc
Copy link
Contributor Author

cagdasc commented Sep 22, 2019

Your welcome 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:porting
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@cagdasc @akien-mga @m4gr3d @Chaosus