Update TextEdit selection when inserting line #31496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulb23
requested changes
Aug 21, 2019
|
It makes sense to make it consistent. But what about just not moving the caret either? I don't really see the purpose of changing anything in the current selection or cursor while disabling a warning. |
|
Yeah that works too, looks like it's only used for disabling warnings and it's not exposed to scripting, so no compatibility breakage. |
|
Cool, I'll do it this way then. |
5fa16cc to
bc839ed
Compare
|
@Paulb23 Changes are done. Now the cursor is adjusted the same way as the selection. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection columns could be invalid after inserting a line in TextEdit (e.g adding warning ignore hints). Now the line indices will be updated when needed, in order to grow or move the selection depending on the case.
Fixes #31458