Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose several GLES3 built-ins to GLES2 #30993

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Expose several GLES3 built-ins to GLES2 #30993

merged 1 commit into from
Aug 1, 2019

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jul 31, 2019 •
edited
Loading

Its implementation of several functions for GLES2 in Spatial and CanvasItem shaders.

  • sinh
  • cosh
  • tanh
  • asinh
  • acosh
  • atanh
  • determinant
  • round*
  • roundEven
  • isnan
  • isinf
  • outerProduct
  • transpose
  • trunc

(*)for Spatial - its already been exposed for Canvas in #30895)

Significant step to close #30940

inverse(mat4) is too hard for me to implement - maybe somebody other can make it !

@Chaosus Chaosus requested a review from reduz as a code owner July 31, 2019 12:02
@Chaosus Chaosus added this to the 3.2 milestone Jul 31, 2019
@Chaosus Chaosus force-pushed the gles2_funcs branch 4 times, most recently from 89ac730 to 99651f7 Compare July 31, 2019 13:30
@clayjohn
Copy link
Member

transpose() and outerproduct() should be wrapped in an #ifndef GLES_OVER_GL statement as they are both implemented for desktop GL but not for GL ES 2.

@Chaosus Chaosus force-pushed the gles2_funcs branch 2 times, most recently from 0fab2c3 to 1b60e21 Compare July 31, 2019 14:23
@Chaosus
Copy link
Member Author

Chaosus commented Jul 31, 2019

@clayjohn Fixed ^^

@clayjohn clayjohn mentioned this pull request Jul 31, 2019
Closed
@akien-mga akien-mga merged commit 8743da9 into godotengine:master Aug 1, 2019
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the gles2_funcs branch August 1, 2019 06:28
@Chaosus Chaosus mentioned this pull request Aug 22, 2019
Merged
@clayjohn clayjohn mentioned this pull request Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
enhancement topic:rendering
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Porting GLES3 built-in functions to GLES2
3 participants
@Chaosus @clayjohn @akien-mga