Fix OpenSimplexNoise get_image() swap axes

[Raphael2048]

fix #30356

[JFonS]

I'm not against this change, but I want to note that it breaks compat with 3.1

[Anutrix]

We can switch p_height and p_width instead of i,j in the for loop,right? Because i,j looks nicer than j,i. Just my opinion.

[aaronfranke]

@raphael10241024 Is this still desired? If so, it needs to be rebased on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

If not, abandoned pull requests will be closed in the future as announced here.

[Raphael2048]

rebased

[aaronfranke]

This fix is very simple and makes sense, currently i is the iterator for the height (Y axis) and j is the iterator for the width (X axis), so the order should be j, i.

The alternative is @Anutrix's suggestion of swapping width and height. I don't think it actually matters which is which, so I guess this depends on @JFonS's personal preference.

[akien-mga]

I also tend to prefer swapping p_width and p_height in the for loops so that we go through (X, Y) instead of (Y, X). But I also don't have a strong opinion either way, it's equivalent.

Edit: Actually let's keep it as is, i and j are used afterwards to index wd8 and changing that wouldn't necessarily be better.

11:47 <jfons> Akien: I don't get what you mean by swapping width and height. Making `i` iterate over width and `j` over height? I don't think that will work...
11:49 <jfons> I would go with what the PR does, it's not that bad. Loops usually iterate over height first to keep memory accesses contiguous and make them more cache-friendly
11:49 <Akien> Hm that's right, I missed that i and j are used afterwards

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.4.

Note that this breaks compatibility. Users who want to preserve the behavior of 3.3 and earlier can swap the arguments in their call to get_image().