Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show icons for code completion options #29744

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Show icons for code completion options #29744

merged 1 commit into from
Jul 5, 2019
+98 −35

Conversation

Geequlim
Copy link
Contributor

@Geequlim Geequlim commented Jun 13, 2019 •
edited
Loading

The second PR based on #29626

  • Show different icons for different type of completion options

Peek 2019-06-09 17-42

@Geequlim Geequlim mentioned this pull request Jun 13, 2019
Merged
@groud
Copy link
Member

groud commented Jun 13, 2019

Wow, that's great ! It looks really pro.

@qarmin
Copy link
Contributor

qarmin commented Jun 13, 2019

I see a lot of flickering, because you probably use Nvidia + Linux, so I recommend to recording a videos with SimpleScreenRecorder, which change some Nvidia settings.

groud
groud reviewed Jun 13, 2019
View reviewed changes
core/script_language.h Outdated Show resolved Hide resolved
@akien-mga akien-mga added this to the 3.2 milestone Jun 13, 2019
Paulb23
Paulb23 requested changes Jun 27, 2019
View reviewed changes
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
@nobuyukinyuu nobuyukinyuu mentioned this pull request Jul 3, 2019
Closed
@nobuyukinyuu
Copy link
Contributor

It was mentioned in #30297 that the readability could be improved by spacing the icon and associated text somewhat further apart. Perhaps an extra pixel or two margin can help?

@Geequlim
Copy link
Contributor Author

Geequlim commented Jul 4, 2019

@Paulb23 Make the icon as property of ScriptCodeCompletionOption and moved the icon definitions from text_edit.cpp to code_editor.cpp.

Also add space between the icons and titles.

@akien-mga Rebased to master and droped the commit in #29626

@akien-mga akien-mga requested a review from Paulb23 July 4, 2019 13:28
Paulb23
Paulb23 previously requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one minor note below.

The completion being editor only is related to #29823

editor/code_editor.cpp Outdated Show resolved Hide resolved
@Geequlim
Copy link
Contributor Author

Geequlim commented Jul 5, 2019

Removed the editor hint checking in code_editor.cpp

@akien-mga akien-mga dismissed Paulb23’s stale review July 5, 2019 06:00

Changes done.

@akien-mga akien-mga merged commit 259a3fb into godotengine:master Jul 5, 2019
@akien-mga
Copy link
Member

akien-mga commented Jul 5, 2019 •
edited
Loading

Thanks for this neat feature!

@YeldhamDev YeldhamDev mentioned this pull request Jul 6, 2019
Closed
@Geequlim Geequlim deleted the gdscript-completion-icons branch October 3, 2019 05:57
@Calinou Calinou mentioned this pull request Dec 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud groud left review comments

@akien-mga akien-mga akien-mga approved these changes

@Paulb23 Paulb23 Paulb23 left review comments

@bojidar-bg bojidar-bg Awaiting requested review from bojidar-bg

@karroffel karroffel Awaiting requested review from karroffel

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@Geequlim @groud @qarmin @nobuyukinyuu @akien-mga @Paulb23 @StraToN