[WIP] Added tooltip delay setting

[Jummit]

closes #27879

[Jummit]

The only thing I have to do now is to replace the isEngine() with a check if the viewport is in the engine editor, then it is good to go.

[akien-mga]

This method doesn't exist...

[Jummit]

Yeah, this is a placeholder for a test if the code is run in the editor. How can I do that?

[akien-mga]

Engine::get_singleton()->is_editor_hint()

[Jummit]

Thanks, I will change that!

[akien-mga]

That code would be problematic though, as when running in the editor you would no longer define gui/timers/tooltip_delay_sec, so it won't appear in the Project Settings to set for the running game. And the call to set_custom_property_info afterwards would fail/run on an undefined value.

So you should keep this GLOBAL_DEF even when running in the editor, but you can then define the gui.tooltip_delay to the EditorSettings parameter when Engine::get_singleton()->is_editor_hint().

[Jummit]

Yes, that sounds like a far cleaner approach.

[Jummit]

When I have

#ifdef TOOLS_ENABLED
if (Engine::get_singleton()->is_editor_hint()) {
	gui.tooltip_delay = EditorSettings::get_singleton()->get("interface/editor/tooltip_delay");
}
#endif

in viewport.cpp, how can I make it not crash in the project selection? There are no other instances where code is run in the project manager that uses EditorSettings.
Even if I use if Main::is_project_manager(), it still crashes:

godot/main/main.cpp

Lines 148 to 155 in 71c784f

	/* Helper methods */
	// Used by Mono module, should likely be registered in Engine singleton instead
	// FIXME: This is also not 100% accurate, `project_manager` is only true when it was requested,
	// but not if e.g. we fail to load and project and fallback to the manager.
	bool Main::is_project_manager() {
	return project_manager;
	}

[akien-mga]

Any editor-specific code in scene should be enclosed in #ifdef TOOLS_ENABLED, otherwise the export template can't build.

[akien-mga]

Actually, this should not be allowed at all as per #29730.

[Calinou]

@Jummit Any plans to update this pull request? 🙂

[akien-mga]

Closing as it's not in a usable state and not getting updated.