Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose minizip API to allow creating zips using scripts #22554

Closed
wants to merge 1 commit into from

Conversation

marcelofg55
Copy link
Contributor

@marcelofg55 marcelofg55 commented Sep 30, 2018

Partially fixes #3701, still no unzipping yet.

Can be used like this:

var z = Zip.new()
z.open("test.zip", Zip.APPEND_CREATE)

z.open_new_file_in_zip("test.txt")
z.write_in_file_in_zip("this is a test".to_utf8())
z.close_file_in_zip()

z.open_new_file_in_zip("test/test.txt")
z.write_in_file_in_zip("this is a test inside a dir".to_utf8())
z.close_file_in_zip()

z.close()

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Sep 30, 2018
@marcelofg55 marcelofg55 force-pushed the zip_module branch 2 times, most recently from 91372da to da1dd2e Compare September 30, 2018 15:02
@akien-mga
Copy link
Member

IMO this is an interesting addition, but I'd prefer to wait for unzipping support before merging this. Having a Zip API that can only create zips but not unzip them would have a fairly limited use case, as most people will typically want to unzip external content.

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Oct 4, 2019
@jameswestman
Copy link
Contributor

Unzip support would be really helpful for my current project. Would anyone mind if I finish this PR?

@akien-mga
Copy link
Member

Go ahead, I don't think Marcelo would mind (they're not very active of the past few months so I don't expect an update on this PR anytime soon).

@aaronfranke
Copy link
Member

Closing as superseded by #34444 as per the above comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zip packing/unpacking with GDScript
4 participants