Minor changes to the AnimationPlayer editor #19475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a2368d to
7ac9279
Compare
akien-mga
reviewed
Jun 10, 2018
| } | ||
|
|
||
| if (path_rect.has_point(p_pos)) { | ||
| return animation->track_get_path(track); | ||
| } | ||
|
|
||
| if (update_mode_rect.has_point(p_pos)) { | ||
| return TTR("Update Mode (How this property is set)."); | ||
| return TTR("Update Mode (How this property is set)"); |
There was a problem hiding this comment.
Why remove the dot here? It's inconsistent with other changes where you add a dot.
There was a problem hiding this comment.
There's no dot because the tooltip itself is not written like a phrase, but like a title ("Update Mode" instead of "Update mode.").
akien-mga
reviewed
Jun 10, 2018
| } | ||
|
|
||
| if (interp_mode_rect.has_point(p_pos)) { | ||
| return TTR("Interpolation Mode"); | ||
| } | ||
|
|
||
| if (loop_mode_rect.has_point(p_pos)) { | ||
| return TTR("Loop Wrap Mode (Interpolate end with beginning on loop"); | ||
| return TTR("Loop Wrap Mode (Interpolate end with beginning on loop)"); |
|
Maybe this pr fix this issue #19481. |
|
@guilhermefelipecgs Yep, it does. |
|
I like Edit as text, Its more consistent with other panels and more friendly usability wise. It's easy to miss that this is an important feature if it's an icon. The other changes are fine. |
|
@reduz Really? To me, it looks really weird having a text-based button in the middle of icon-based ones. |
fdb2d38 to
e926a1f
Compare
|
Very well, the button is back to being text-based. |
e926a1f to
ad02967
Compare
1a54701 to
cc036a6
Compare
cc036a6 to
0218129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
really insert key?printing for when inserting keys in an audio track.