Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate Batch Rename from scene-tree menu #19268

Merged
merged 1 commit into from
May 30, 2018

Conversation

swarnimarun
Copy link
Contributor

I, while working on something came across a this duplicate so thought why not remove it.

@akien-mga akien-mga added this to the 3.1 milestone May 30, 2018
@akien-mga akien-mga merged commit 28fa82c into godotengine:master May 30, 2018
@swarnimarun swarnimarun deleted the minor_fixes branch August 3, 2018 18:31
@bfloch
Copy link
Contributor

bfloch commented Jan 23, 2019

@swarnimarun Did this create two entries? It should replace the default one.
This PR removed the batch rename dialog from the menu.
When multiple nodes are selected I would argue that it should use this dialog instead of the default behaviour which can not handle multiple nodes.

This is probably the reason why the batch rename dialog got skipped from the changelog @akien-mga
You can still access it via CTRL+F2.

@swarnimarun swarnimarun restored the minor_fixes branch January 23, 2019 05:43
@swarnimarun
Copy link
Contributor Author

@bfloch Thanks for pointing it out let me quickly fix it...

@swarnimarun
Copy link
Contributor Author

@bfloch What's the problem? Cause I am not able to see how it is causing a problem, the place it now makes more sense as the comment says.

@akien-mga
Copy link
Member

I also don't see what's the problem.
screenshot_20190123_103428

@Calinou Apparently the Batch Rename scene tree tool is not listed in the changelog yet, see #15928.

@Calinou
Copy link
Member

Calinou commented Jan 23, 2019

@akien-mga I just added it to the changelog.

@swarnimarun swarnimarun deleted the minor_fixes branch January 23, 2019 17:15
@bfloch
Copy link
Contributor

bfloch commented Jan 24, 2019

I think I know where my confusion comes from.
If you have child nodes selected it only shows "Rename".

batch_rename

Batch Rename works well for hierarchies, has per level Options etc.
Now I am not sure if that's me messing up since it was so long ago, but I thought it worked at some point.

@Calinou Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants