Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement seek operation for Theora video files #102360

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
+595 −415
Open

Implement seek operation for Theora video files #102360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f247532
Fix playing of video Theora files
berarma Jan 23, 2025
00fb5c4
Crop image when doing color space conversion
berarma Feb 12, 2025
5b67dda
Update servers/audio/audio_rb_resampler.h
berarma Feb 13, 2025
2427807
Replace memnew with instantiate
berarma Feb 13, 2025
3e0c4e4
Implement seek operation in Theora video files
berarma Jan 28, 2025
dbdb401
Use permanent audio buffer
berarma Feb 10, 2025
b835b82
Add 8-channel audio support
berarma Feb 10, 2025
4f0001d
Downmix 4/6/8-channel audio to stereo
berarma Feb 10, 2025
d3624b3
Clear state before setting new file
berarma Feb 11, 2025
50b23d5
Dynamic audio buffer size
berarma Feb 11, 2025
21e9e74
Don't start decoding video before keyframe
berarma Feb 11, 2025
03655d6
Update modules/theora/video_stream_theora.cpp
berarma Feb 13, 2025
5e2887b
Update modules/theora/video_stream_theora.cpp
berarma Feb 13, 2025
08c28d1
Update modules/theora/video_stream_theora.cpp
berarma Feb 13, 2025
3d56b09
Clean up switch/case
berarma Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions doc/classes/VideoStreamPlayer.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<return type="float" />
<description>
The length of the current stream, in seconds.
[b]Note:[/b] For [VideoStreamTheora] streams (the built-in format supported by Godot), this value will always be zero, as getting the stream length is not implemented yet. The feature may be supported by video formats implemented by a GDExtension add-on.
</description>
</method>
<method name="get_stream_name" qualifiers="const">
Expand Down Expand Up @@ -79,7 +78,6 @@
</member>
<member name="stream_position" type="float" setter="set_stream_position" getter="get_stream_position">
The current position of the stream, in seconds.
[b]Note:[/b] Changing this value won't have any effect as seeking is not implemented yet, except in video formats implemented by a GDExtension add-on.
</member>
<member name="volume" type="float" setter="set_volume" getter="get_volume">
Audio volume as a linear value.
Expand Down
Loading
Loading