Initialize pa_buffer_attr.maxlength to -1 #102069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not an expert on the audio system so hesitant to do more than having a quick look. Reading the documentation, leaving this property uninitialized seems like a bad idea. Seeing they themselves recommend setting this to -1 so the buffer is allocated with the maximum supported size, this change seems sound. |
akien-mga
reviewed
Jan 27, 2025
| @@ -726,6 +726,7 @@ Error AudioDriverPulseAudio::init_input_device() { | |||
| int input_buffer_size = input_buffer_frames * spec.channels; | |||
|
|
|||
| pa_buffer_attr attr; | |||
There was a problem hiding this comment.
I'd suggest also zeroing the struct so at least we have sane defaults if we end up relying on some of the other struct fields.
Suggested change
| pa_buffer_attr attr; | |
| pa_buffer_attr attr = {}; |
1bbf8ed to
b5622e9
Compare
akien-mga
approved these changes
Jan 27, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102013 (and other long term unreliabilities of the pulseaudio microphone on Linux) by initializing and uninitialized buffer definition attribute to -1 as recommended here: https://maemo.org/api_refs/5.0/5.0-final/pulseaudio/structpa__buffer__attr.html
The other three attributes (tlength, prebuf, minreq) are not used by the recording feature
pa_stream_connect_record()and probably don't have to be initialized.