New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for `StreamPeerTCP` #102064

Open

wheatear-dev wants to merge 1 commit into godotengine:master from wheatear-dev:test-stream-peer-tcp

+304 −0

Contributor

wheatear-dev commented Jan 26, 2025

Adds unit tests for StreamPeerTCP, using a mock implementation of NetSocket (#43440).

Includes:

Boundary testing of port bindings
State transitions (e.g. receiving a FIN message)
Streaming ascii-encoded data on:
- StreamPeerTCP::put_data()
- StreamPeerTCP::get_data()

Several public methods on StreamPeerTCP are tested, but more remain untested - this can be addressed in later PR's if required.

I particularly welcome suggestions for the manual memory management in the latter few sub-cases - this feels like an anti-pattern.

Thanks! 😌


          Add unit tests for StreamPeerTCP

396cd5a

wheatear-dev requested a review from a team as a code owner

January 26, 2025 18:56

AThousandShips added enhancement topic:network topic:tests labels

AThousandShips added this to the 4.x milestone

AThousandShips requested a review from a team

January 27, 2025 08:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement topic:network topic:tests