-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heightfield mask to GPUParticlesCollisionHeightField3D #101947
Conversation
a5a7c00
to
d4f3fda
Compare
d31771d
to
0d00dc0
Compare
@clayjohn, I changed to comparing
|
0d00dc0
to
ef1ef05
Compare
You shouldn't change the default value to support this. You would be potentially breaking users' games in order to make something easier in the editor. |
ef1ef05
to
14716ca
Compare
I have removed the default value change. I’m not entirely sure what happened. At some point during my testing, it was necessary to change the default value, but when I started testing again today, it was no longer required to fix the bug. |
I see, I just reloaded the stored cull_mask in the project instead of the default one. |
14716ca
to
8115065
Compare
cull_mask
8115065
to
e3508c4
Compare
cull_mask
e3508c4
to
eea37c8
Compare
As discussed in the rendering meeting I pivoted to adding a specific mask to GPUParticlesCollisionHeightField3D. This allows us not to break compatibility and to better match expected behavior. I added @yahiaetman as a co-auther since I based this of their work in #93291 |
eea37c8
to
2be6d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some fixes for the documentation. The code looks great!
I wasn't able to reproduce the MRP, but I trust that you have tested carefully and can confirm that it is working properly
…its layer_mask Co-authored-by: Yahia Zakaria <yahiazakaria13@gmail.com>
2be6d13
to
b162c59
Compare
Thanks! |
Fixes #101750
As described in the issue, particles would collide with the icon of any node within the
GPUParticlesCollisionHeightField3D
AABB. Additionally, I noticed that an object's layer mask had no effect on whether it was considered by the height field.This change addresses both issues.