Fix ColorPicker hide save/load swatches for presets_visible #101913
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you hide presets while the section is unfolded, the unfolded controls stay visible: godot.windows.editor.dev.x86_64_yNEbPD5hmu.mp4Also disabling presets does not hide their parent container, leaving extra margin. A more robust solution would be putting all swatches-related nodes into their own VBoxContainer and toggling its visibility instead of individual controls. |
f0ec16a to
e9b164a
Compare
|
Moved swatch related controls into a VBoxContainer as suggested. |
KoBeWi
approved these changes
Jan 28, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #101908
Hides the menu button for loading and saving swatches when presets_visible is false.
This PR does not fix "You can load a new palette even if can_add_swatches = false" mentioned in the issue