Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of ClassDB-bound methods changed #8742

Closed
jmf opened this issue May 13, 2017 · 2 comments
Closed

Names of ClassDB-bound methods changed #8742

jmf opened this issue May 13, 2017 · 2 comments

Comments

@jmf
Copy link
Contributor

jmf commented May 13, 2017

Operating system or device - Godot version:
Linux 4.11
Godot master e883cda

Issue description:
Some bound methods were renamed in 3.0. This brings issues, when those methods are called from C++ code. This is an example from scene/gui/tree.cpp:
v_scroll->call_deferred("set_val", ofs - screenh + h);
It fails (silently) because "set_val" was renamed into "set_value" in 3.0.

This probably happens in other files, too. Checking all occurrences of call_deferred() and related functions that call bound methods will be necessary.
Also displaying an error when a call fails would make debugging easier.

The example above is the cause for a bug, where trees don't scroll when using the arrow-down key to navigate.

@27thLiz 27thLiz added this to the 3.0 milestone May 13, 2017
@akien-mga akien-mga changed the title [3.0] Names of ClassDB-bound methods changed Names of ClassDB-bound methods changed May 18, 2017
@akien-mga
Copy link
Member

That's typically something that any contributor could do by grepping for call_deferred and checking manually all of them. Have fun :)

@reduz
Copy link
Member

reduz commented May 23, 2017

that was the only one in all the source code..

groscalin pushed a commit to groscalin/godot that referenced this issue Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants