Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup Symbol does not always work (regression in 4.0 RC 1) #73167

Closed
ghost opened this issue Feb 12, 2023 · 6 comments · Fixed by #73196
Closed

Lookup Symbol does not always work (regression in 4.0 RC 1) #73167

ghost opened this issue Feb 12, 2023 · 6 comments · Fixed by #73196

Comments

@ghost
Copy link

ghost commented Feb 12, 2023

Godot version

v4.0.rc1.official [8843d9a]

System information

Windows 11 Pro 64Bit

Issue description

Hi,

Found a rather annoying bug in 4.0 RC1 official on Windows 11:
When right clicking on a function in code and selecting "Lookup Symbol" - it does not always work?
Sometimes it works, sometimes it does not work?

Any ideas?

Jesse

Steps to reproduce

Right click on a function in code and select "Lookup Symbol".
(it does not work always?)

Minimal reproduction project

N.A.

@KoBeWi
Copy link
Member

KoBeWi commented Feb 12, 2023

Yeah symbol lookup seems to have problems.
For me it fails for autoloads: #73058
Might be same issue.

@Calinou
Copy link
Member

Calinou commented Feb 12, 2023

@BetaMaxHero Please upload a minimal reproduction project to make this easier to troubleshoot.

If you paste the same script in 3.5.1 (and adapt it so it works there), does Lookup Symbol work there?

@Calinou Calinou changed the title [4.0 RC1 Win 11] - Right-Click On Function - "Lookup Symbol" - Does Not Always Work? Lookup Symbol does not always work Feb 12, 2023
@ghost
Copy link
Author

ghost commented Feb 12, 2023

Hi,

Was using 3.x before using 4.0, and this was never an issue.
I went back to 4.0 Beta 17 and it works 100%.

"Lookup Symbol" is an IDE feature I use ALOT.
Definitely something wrong with 4.0 RC1

Jesse

@akien-mga
Copy link
Member

Might be a regression from #72789 then, CC @Vilcrow @vnen.

@akien-mga akien-mga added this to the 4.0 milestone Feb 12, 2023
@akien-mga akien-mga changed the title Lookup Symbol does not always work Lookup Symbol does not always work (regression in 4.0 RC 1) Feb 12, 2023
@Vilcrow
Copy link
Contributor

Vilcrow commented Feb 13, 2023

I tested this in 3.5.1.stable on Ubuntu, there was a similar problem: the Lookup Symbol button not always work. I think the reason isn't #72789, but this fix doesn't work correctly: Ctrl+Click will always lead to a function in the current script, even if it is a method of another class. I will deal with this issue.
@KoBeWi I couldn't reproduce #73058 on Ubuntu. My bad. I clicked the wrong way.

@Vilcrow
Copy link
Contributor

Vilcrow commented Feb 13, 2023

I think I fix mistake in #72789 by #73196. I will think about fixing #73167. It may be possible to include a solution to this bug in the same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants