Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when selecting file using "Keep" importer in FileSystem dock #47296

Closed
akien-mga opened this issue Mar 23, 2021 · 0 comments · Fixed by #47298
Closed

Errors when selecting file using "Keep" importer in FileSystem dock #47296

akien-mga opened this issue Mar 23, 2021 · 0 comments · Fixed by #47298

Comments

@akien-mga
Copy link
Member

akien-mga commented Mar 23, 2021

Godot version:
cd05653, after #47268.

OS/device including version:
Linux, but should happen on any OS.

Issue description:
When using the new "Keep" import mode for a given file (here CSV), the following errors can be reproduced:

  1. When you select the file in the FileSystem dock with a single mouse click, this error is printed:
ERROR: Couldn't find the given section "remap" and key "type", and no default was given.
   at: get_value (core/io/config_file.cpp:85)
  1. When you double-click the file, or "open" it with ui_accept, the following errors are raised:
ERROR: Resource file not found: .
   at: _load (core/io/resource_loader.cpp:207)
ERROR: Failed loading resource: res://test.csv. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:202)
ERROR: Condition "!res.is_valid()" is true. Returning: ERR_CANT_OPEN
   at: load_resource (editor/editor_node.cpp:1016)
  1. The CSV is shown with a "broken import" icon. It should likely use a "plain file" icon instead.

Screenshot_20210323_145923

Steps to reproduce:
See above.

Minimal reproduction project:
CSVImporterKeep.zip

@akien-mga akien-mga added this to the 4.0 milestone Mar 23, 2021
reduz added a commit to reduz/godot that referenced this issue Mar 23, 2021
* Removes error shown when file is in 'keep' mode
* Display a warning when attempting to open the file
* Closes godotengine#47296
akien-mga pushed a commit to akien-mga/godot that referenced this issue Mar 23, 2021
* Removes error shown when file is in 'keep' mode
* Display a warning when attempting to open the file
* Closes godotengine#47296

(cherry picked from commit 4706297)
geekrelief pushed a commit to geekrelief/godot that referenced this issue Apr 5, 2021
* Removes error shown when file is in 'keep' mode
* Display a warning when attempting to open the file
* Closes godotengine#47296

(cherry picked from commit 4706297)
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this issue Apr 24, 2021
* Removes error shown when file is in 'keep' mode
* Display a warning when attempting to open the file
* Closes godotengine#47296

(cherry picked from commit 4706297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant