Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rotate device cause crash on iOS #11630

Closed
alexzheng opened this issue Sep 27, 2017 · 2 comments
Closed

rotate device cause crash on iOS #11630

alexzheng opened this issue Sep 27, 2017 · 2 comments
Labels
archived bug platform:ios topic:porting

Comments

@alexzheng
Copy link

alexzheng commented Sep 27, 2017 •
edited by akien-mga
Loading

Operating system or device, Godot version, GPU Model and driver (if graphics related):
godot 2.1
iOS 10

Issue description:

2017-09-27 18:47:06.125802+0800 godot_opt.iphone[929:199778] [App] if we're in the real pre-commit handler we can't actually add any new fences due to CA restriction
2017-09-27 18:47:06.125918+0800 godot_opt.iphone[929:199778] [App] if we're in the real pre-commit handler we can't actually add any new fences due to CA restriction
******** screen size 640, 1136
******** screen size 640, 1136
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x10)
    frame #0: 0x0000000183a6c150 libobjc.A.dylib`objc_msgSend + 16
    frame #1: 0x000000018b378bf0 UIKit`-[UIClientRotationContext rotateSnapshots] + 476
    frame #2: 0x000000018b1a853c UIKit`-[UIWindow _setRotatableClient:toOrientation:updateStatusBar:duration:force:isRotating:] + 4900
    frame #3: 0x000000018b1a70bc UIKit`-[UIWindow _setRotatableViewOrientation:updateStatusBar:duration:force:] + 148
    frame #4: 0x000000018b19dc54 UIKit`__57-[UIWindow _updateToInterfaceOrientation:duration:force:]_block_invoke + 124
    frame #5: 0x000000018b129ca8 UIKit`-[UIWindow _updateToInterfaceOrientation:duration:force:] + 472
    frame #6: 0x0000000184f915f4 CoreFoundation`__CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 20
    frame #7: 0x0000000184f90d08 CoreFoundation`_CFXRegistrationPost + 400
    frame #8: 0x0000000184f90a84 CoreFoundation`___CFXNotificationPost_block_invoke + 60
    frame #9: 0x0000000184fff7a8 CoreFoundation`-[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1412
    frame #10: 0x0000000184ed495c CoreFoundation`_CFXNotificationPost + 376
    frame #11: 0x00000001859e7930 Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:] + 68
    frame #12: 0x000000018b1297f4 UIKit`-[UIDevice setOrientation:animated:] + 324
    frame #13: 0x000000018b3c0e20 UIKit`__54-[UIApplication _handleDeviceOrientationChangedEvent:]_block_invoke + 88
    frame #14: 0x000000018b3c0d90 UIKit`-[UIApplication _handleDeviceOrientationChangedEvent:] + 140
    frame #15: 0x000000018b129598 UIKit`-[UIApplication handleEvent:withNewEvent:] + 1440
    frame #16: 0x000000018b128e90 UIKit`-[UIApplication sendEvent:] + 100
    frame #17: 0x000000018b193c14 UIKit`_UIApplicationHandleEvent + 404
    frame #18: 0x000000018693e8a0 GraphicsServices`_PurpleEventCallback + 744
    frame #19: 0x000000018693e390 GraphicsServices`PurpleEventCallback + 32
    frame #20: 0x0000000184fa5ae4 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 56
    frame #21: 0x0000000184fa5284 CoreFoundation`__CFRunLoopDoSource1 + 436
    frame #22: 0x0000000184fa2d98 CoreFoundation`__CFRunLoopRun + 1752
    frame #23: 0x0000000184ed2da4 CoreFoundation`CFRunLoopRunSpecific + 424
    frame #24: 0x000000018693d074 GraphicsServices`GSEventRunModal + 100
    frame #25: 0x000000018b18dc9c UIKit`UIApplicationMain + 208
  * frame #26: 0x0000000100177650 godot_opt.iphone`main(argc=1, argv=0x000000016fdcb948) at main.m:45
    frame #27: 0x0000000183ee159c libdyld.dylib`start + 4
(lldb)

Steps to reproduce:
set the supported orientations all on in the project and run on the device and rotate it several times, it crash.

Link to minimal example project:
@mhilbrunner
Copy link
Member

Can you try if this happens with 3.0 too?

@Calinou
Copy link
Member

Calinou commented Jun 7, 2020

Closing due to lack of response (see @mhilbrunner's comment above). Please comment if you can still reproduce this bug with Godot 3.2.1 or 3.2.2beta4.

@Calinou Calinou closed this as completed Jun 7, 2020
knackname added a commit to knackname/godot that referenced this issue Jan 26, 2025
@knackname
Add direction property to AtlasTexture
09fe820 
In response to issue godotengine#11630 on the godot-proposals repo

Adds direction property to AtlasTexture
Also adds Direction enum as a variant mapping to int with the 4 cardinal directions: NORTH, EAST, SOUTH, WEST

The direction property dictates the direction the region is drawn in, allowing AtlasTexture to support atlases with rotated members
onesuchkeeper added a commit to onesuchkeeper/godot that referenced this issue Jan 26, 2025
@onesuchkeeper
Add direction property to AtlasTexture
ebcb4e4 
ref godot-proposals issue godotengine#11630

Added enum 'Direction' as a variant with possible values: NORTH, EAST, SOUTH, WEST

Added 'direction' property of type 'Direction' to AtlasTexture. When drawing the region specified by the AtlasTexture it will be drawn with its specified direction facing up.

This is done to support Atlases with rotated members, which is a common practice for optimization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
archived bug platform:ios topic:porting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Calinou @alexzheng @mhilbrunner @akien-mga