Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3 release page #878

Closed
wants to merge 42 commits into from

Conversation

adamscott
Copy link
Member

@adamscott adamscott commented Jul 4, 2024

Important

I need your help! See the note below on how you can help me.

Preview of the release page

image

Help needed

I need help to prepare demos for the media. I've done some already, but I need to fill all the media spots that say: "TODO: replace me".

If you plan to create a demo, please comment and say so. It will save some time for everyone.

What I mean by demo

What I mean by demo is a simple project that I can unpack on my machine and capture the content, either with an image or by recording the content. I'll use my Macbook Pro as it has a nice resolution/high DPI.

Demos missing

  • (Outstanding) Interactive music support
  • (Outstanding) TilemapLayer node
  • (2D) Parallax2D node
  • (GDScript) GDScript autocompletion fixes
  • (Rendering) Premultiplied alpha blending in 3D shaders
  • (Web) splashscreen now showing up
  • (XR) Composition layers to allow 2D viewports to be displayed at much higher quality
  • (XR) Standardized and enhanced support for hand/finger tracking, body tracking, and face tracking

@adamscott adamscott added the topic:releases Issues and PRs related to new engine releases label Jul 4, 2024
@adamscott adamscott requested a review from coppolaemilio July 4, 2024 15:42
@coppolaemilio
Copy link
Member

Style

The download section should be the first thing on the page, you can add the video and the rest of the features afterwards. Most people will come just for the download, and making them scroll should be optional.

I think we can use the hero to highlight an image of a game, something like PVKK instead of having the logo two times.
While the monochrome style looks nice, it gets a bit confusing when comparing versions:
image

The padding in the title is inconsistent, and making the font too big requires for more space for it to not feel too crammed:
image

The donate button doesn't look like a button, and the background of the godot logos cutting don't look like there is a bug in the site.
image

There isn't enough contrast in "accent" titles for the cards that have gradient backgrounds, the words "Layer up" are difficult to read:
image

I'm not sure if mobile was supposed to be in already or if that is something to be added in the future, because it looks incomplete in most of the cases.

Code

I would recommend to split the css into a .scss file (it can be in the same directory).

I would replace the grid-template areas with more generic column layouts and use those names instead of describing the content of them.

grid-template-areas:
	/* Header */
	"presentation"
	"foundation"
	"cannot-wait"
	"spacer-after-cant-wait"
	/* Features: */
	"outstanding"
	/* Features alphabetically ordered: */
	"_2d"
	"animation"
	"dotnet" /* Should read as "C#". */
	"documentation"
	"display"
	"editor"
	"gdscript"
	"rendering"
	"web"
	"xr"
	/* Footer */
	"spacer-before-download"
	"download";

If we were going to reuse this for the base for a future page, we would need to start renaming all the template areas which will be a bit of a mess. So by using agnostic names like span-col-2.

I don't understand the need to make a shadow-root with this much style for each element:
image
Everything that is currently implemented can be achieved with minimal css and standard html.
There is a lot of stuff being generated with Javascript without any real need, so I would try to instead of reinventing how to render elements in html I would stick to standards.

@JohnVeness
Copy link
Collaborator

Looking at the preview image you kindly put above, I see a typo of "orignially". Also "open source game engine" should be "open-source game engine". Probably more but it's quite hard to read and edit the 4.3.html file, with so much stuff around the blocks of text.

Also, there seems to be a lot of hyphenation where I wouldn't expect it. It looks odd seeing words like "hundreds" or "platform" hyphenated.

@Calinou
Copy link
Member

Calinou commented Jul 4, 2024

I'll look into creating a premultiplied alpha blending demo (most likely a VFX/particles comparison with and without premultiplied alpha).

Edit: I made something, what do you think? It showcases how a premultiplied alpha material can exhibit both additive and mix blending at the same time (while the Mix/Add blend modes can only do one of those at once).

blend_mode_premul_alpha.mp4.zip

Project files: test_3d_premul_alpha.zip

Also, what's the expected aspect ratio for the video?

@adamscott
Copy link
Member Author

If we were going to reuse this for the base for a future page, we would need to start renaming all the template areas which will be a bit of a mess.

The grid system was used because it decouples the declaration from the presentation. We need to switch up the order last minute? No problem, we just have to switch it there instead of copy pasting large swaths of code.

If we were going to reuse this for the base for a future page, the categories wouldn't change much, so I'm not worried about this.

I don't understand the need to make a shadow-root with this much style for each element:

This style inside the shadow-root is only repeated there for convenience. It isn't repeated download-wise, "declared once, used multiple times".

I would try to instead of reinventing how to render elements in html I would stick to standards.

With all due respect, this is standard.

@coppolaemilio
Copy link
Member

With all due respect, this is standard.

Well, if that is a standard we are truly lost in the web front ⚰️🪦

@adamscott
Copy link
Member Author

By the way, a new PR will be made, I'm creating a other version based on @coppolaemilio's comments.

@adamscott adamscott closed this Jul 14, 2024
@adamscott adamscott mentioned this pull request Jul 14, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:releases Issues and PRs related to new engine releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants