Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support EditorVCSInterface v2 #84

Merged
merged 62 commits into from
Jan 10, 2022
Merged

Update to support EditorVCSInterface v2 #84

merged 62 commits into from
Jan 10, 2022

Conversation

twaritwaikar
Copy link
Contributor

This PR updates #47 with the newer bindings that would result from godotengine/godot#53371

@twaritwaikar twaritwaikar mentioned this pull request Oct 3, 2021
Closed
@twaritwaikar twaritwaikar changed the title [WIP] Updated VCS Integration v2 [WIP] Update to support EditorVCSInterface v2 Oct 3, 2021
@twaritwaikar twaritwaikar mentioned this pull request Oct 3, 2021
Closed
@twaritwaikar
Copy link
Contributor Author

Currently, pushing commits when there is no need to seems to crash the plugin. See bug report libgit2/libgit2#6087

@twaritwaikar twaritwaikar force-pushed the update-vcs-new branch 2 times, most recently from 8c24d26 to ea9c1de Compare October 12, 2021 21:46
@twaritwaikar
Copy link
Contributor Author

Tested commit functionality on macOS x64 ✔️
Network features on macOS are still untested but they will probably work if we have got so far.

@twaritwaikar twaritwaikar force-pushed the update-vcs-new branch 5 times, most recently from 67f0ec1 to 4da6f9a Compare October 13, 2021 12:30
@twaritwaikar twaritwaikar force-pushed the update-vcs-new branch 2 times, most recently from 563316c to cc9632e Compare October 13, 2021 20:14
@twaritwaikar twaritwaikar marked this pull request as ready for review October 15, 2021 11:38
@twaritwaikar twaritwaikar changed the title [WIP] Update to support EditorVCSInterface v2 Update to support EditorVCSInterface v2 Oct 15, 2021
@twaritwaikar
Copy link
Contributor Author

twaritwaikar commented Oct 15, 2021 •
edited
Loading

Needs godotengine/godot#53371 godotengine/godot#53900

@twaritwaikar twaritwaikar mentioned this pull request Nov 14, 2021
Open
@twaritwaikar twaritwaikar mentioned this pull request Dec 25, 2021
Closed
@twaritwaikar twaritwaikar merged commit ceb6681 into godotengine:master Jan 10, 2022
@twaritwaikar twaritwaikar deleted the update-vcs-new branch January 10, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twaritwaikar @Calinou @Janglee123