Improve theming documentation #5180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a127578 to
e5ac254
Compare
YuriSizov
commented
Aug 16, 2021
e5ac254 to
fe926b8
Compare
|
I've added a screenshot of a real game using heavily skinned controls, looks something like this now (permission, and that specific image, granted by developers):
|
|
Also, cc @skyace65 as you've recently spent time on this and are familiar with the topic |
fe926b8 to
f211483
Compare
hpnrep6
reviewed
Aug 18, 2021
f211483 to
0cb5e6e
Compare
|
Thanks, @hpnrep6. I've rephrased a couple of places completely based on your feedback. |
|
I think this is good to go :) Thanks for working on this! |
This was referenced Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the GUI skinning/theming documentation, that builds upon #5162. I've written a new skinning tutorial that tries to explain the basic concepts of the control nodes and themes, and I've used the old article as a piece on the theme editor which I've also improved upon.
To wrap the whole thing a bit better I've also changed the index page for the user interface tutorials.
This probably needs some editing for style and whatnot, but from the content standpoint it should be better than we had before.
This shouldn't be cherrypicked for 3.4, as it features some concepts only available in
master. It'd be better if I made a separate 3.4 PR when we finalize this one.