-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2D particles page for Godot 4.4 #10597
Conversation
f59faf4
to
904a8df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images look good, as long as we don't care about the quick open icon being present.
I commented on obvious grammar, spelling, and inaccuracies I found.
There are a lot of style changes I'd like to make to match the new standard guidelines but I think that's fine to defer to keep the diff in this PR more straightforward.
tutorials/2d/img/particles_flipbook_create_canvasitemmaterial.webp
Outdated
Show resolved
Hide resolved
…2d.rst rename title
904a8df
to
95946bf
Compare
Applied most of tetrapods suggestions (commented on the one I didn't do) and the images showing the folder icon have been redone |
"This PR is an update" :D Well, this is a merge! As always, thank you (and thanks tetra for the reviews!) |
This PR is an update, though mostly re-organizing of the 2D particle page for Godot 4.4. New images have all been taken in Godot 4.4, but a lot of this reorganization is relevant to 4.0 and onward, looks like this page wasn't gone through yet. Did the following:
Other than what I did for Angular velocity no new settings descriptions have been made, and both pages are missing a lot and need to be updated further. For the sake of making a review easier and my lack of familiarity with the specifics of particles I figured a good first step would just be to get this all properly organized and make sure there's at least nothing inaccurate in the information that is given, rather than try to do everything at once.