-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI in nodes-and-scenes #10589
Update UI in nodes-and-scenes #10589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
In the future you don't need to include the images in the PR description. But if you want to take the time, it can help, because GitHub's tools for comparing webp files are really bad
As for width:
- As a rule, new images don't have to match old image dimensions exactly.
- Image width must be less than 1920 pixels (we have a rule that images must be smaller than 1080p, which is 1920x1080)
- UI screenshots should be less than ~796 pixels wide if you can, so that they fit in the content column of the docs with no scaling issues. But this isn't a hard rule and it's not written down anywhere. You can't always make screenshots of the whole editor this small, either.
So overall your images fit the guidelines just fine.
Cool, thanks! Given the images currently fir the guidelines (and that image 3 and 4 have the same width), I'll leave them as is, then. Thanks! |
I'm going to say no to merging this PR. We're a month or less out from 4.4 and will need to update these screenshots for that anyway because of the new game workspace. In addition you did Lossy compression on these images which we explicitly do not want, and I can see the artifacts from compression. |
Sure, no problem! |
I think retaking the screenshots, and only targetting 4.4 would be fine.
@skyace65 Does that sound okay, did I miss any steps here? |
Tetrapod's instructions are perfect, and those are the squoosh settings I use for my own doc images. So yes if you want you can re-do this PR with screenshots from 4.4. You can either build from master like you said, or use the latest beta from the Godot website, either is fine. |
ebd4294
to
96d6cdd
Compare
Updated images using 4.4, but just realized we do not have a 4.4 branch yet. Do I leave it based on master for now and we wait until 4.4 is released? |
For upcoming releases you just use the master branch. Generally you should always use the master branch except for specific circumstances. As an example, say 4.4 releases in a month and two weeks later you want to make a PR that applies to 4.4 and the master branch. You would make the PR for the master branch, and we would add a "cherrypick 4.4" label to the PR, so the contents of that PR would be added to the 4.4 branch when we do the next round of cherrypicks. You would only make a PR for the 4.4 branch, 4.3, etc, if the change you're making applies to that branch but does not apply to the master branch, or if it's a change that was already made to the master branch that can't be cherry picked easily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks okay to me. This time I checked for lossy artifacts.
getting_started/step_by_step/img/nodes_and_scenes_05_editor_with_label.webp
Show resolved
Hide resolved
96d6cdd
to
b38b1bc
Compare
Oh, I was under the impression that merging to master would publish to the website instantly. Had forgotten that it needs to then be cherry picked to update the 4.3 docs. Thanks for the explanation! |
Thanks! And congrats on your first merged PR! |
This PR updates screenshots from the nodes-and-scenes step from the step-by-step guide.
There are two main changes:
Create New Node
window now specifies the Class much more clearly.Questions:
Image diffs:
File: getting_started/step_by_step/img/nodes_and_scenes_01_empty_editor.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_03_create_node_window.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_04_create_label_window.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_05_editor_with_label.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_08_hello_world_text.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_10_save_scene_as.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_11_final_result.webp
Old:
New:
File: getting_started/step_by_step/img/nodes_and_scenes_14_select_main_scene.webp
Old:
New: