Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes about automatic .app bundle creation to compiling for macOS page. #10580

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Add notes about automatic .app bundle creation to compiling for macOS page. #10580

merged 1 commit into from
Jan 31, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 30, 2025

Adds build instructions and notes about automatic editor bundle generation (the same is already added for export templates).

@bruvzg bruvzg added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation platform:macos labels Jan 30, 2025
@bruvzg bruvzg added this to the 4.4 milestone Jan 30, 2025
skyace65
skyace65 requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick. Can't speak to technical accuracy but grammar and spelling for everything else looks good.

contributing/development/compiling/compiling_for_macos.rst Outdated Show resolved Hide resolved
skyace65
skyace65 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do think it should be read as "dot-app" and use "a" instead of "an" I'd rather merge this as is instead of holding this up for my nitpicking.

@skyace65 skyace65 merged commit 3e17624 into godotengine:master Jan 31, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement platform:macos
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @skyace65 @mhilbrunner @AThousandShips