-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point mapping contributions to Godot in Controllers, gamepads and joysticks #10569
Point mapping contributions to Godot in Controllers, gamepads and joysticks #10569
Conversation
I would remove any explicit reference to https://github.com/gabomdq/SDL_GameControllerDB/ as we shouldn't be sending users there, since they made it clear our use case is out of scope for them. That's their prerogative and it's totally fair, we seem to have misinterpreted how much overlap there is between our needs for SDL-compatible mappings, and SDL's own need for a mapping DB for those not supported out of the box by its driver. If we do find bugs in mappings needed for SDL itself, we can contribute them back, but this should be done by Godot maintainers after properly evaluating that they're in scope for SDL, and not by Godot users. FYI @offalynne |
Thanks ! For what it's worth I'm perfectly happy to accept SDL-compatible mappings upstream, the problem is that testing with Godot's gamepad tools may produce mappings incompatible with SDL and vice versa; working out those incompatibilities should ideally not be a persistent issue for either party. The SDL community db gets a lot of issues related to downstream software that are beyond our scope, and I don't want that maintenance burden given Godot does not presently use SDL so the HIDAPI/XInput/etc. drivers do not interoperate. I'm content to skim If the GameControllerDB repo continues to see incompatible contributions from Godot users I'll update our README to reflect this change as well |
…sticks GameControllerDB's upstream does not accept contributions from Godot since it does not use SDL. Users can still create custom mappings, but they should be submitted to Godot's controller database instead of the SDL one. This also adds a reference to `godotcontrollerdb.txt` which was missing in the first place. This file is used as a complement to `gamecontrollerdb.txt`.
c508857
to
cbdec4e
Compare
Thanks, and thanks for the reviews! |
GameControllerDB's upstream does not accept contributions from Godot since it does not use SDL. Users can still create custom mappings, but they should be submitted to Godot's controller database instead of the SDL one.
This also adds a reference to
godotcontrollerdb.txt
which was missing in the first place. This file is used as a complement togamecontrollerdb.txt
.