Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Getting Started for Parallax2D #10565

Merged

Conversation

markdibarry
Copy link
Contributor

Adds a short "Getting Started" section to clarify where to place textures. Also, updates image to show the example's node tree.

Closes #10512

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to add this, however I think this could still be a little more specific about exactly which nodes can be used

Also, for posterity's sake, in #10462 we updated our dependency on sphinxcontrib-video, which added the ability to specify alignment for videos in sphinx-contrib/video#40. However that changed the existing unspecified alignment behavior, so in this PR the alignment of the video is specified as center to match the prior behavior. The video alignment is handled by #10566 instead now

tutorials/2d/2d_parallax.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_parallax.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_parallax.rst Outdated Show resolved Hide resolved
@tetrapod00 tetrapod00 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:2d cherrypick:4.3 labels Jan 29, 2025
@markdibarry markdibarry force-pushed the parallax2d-getting-started branch from cabdd3c to 737a721 Compare January 29, 2025 14:15
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, besides a possibly-forgotten section header

tutorials/2d/2d_parallax.rst Show resolved Hide resolved
@markdibarry markdibarry force-pushed the parallax2d-getting-started branch from 013b84f to 692efa2 Compare January 29, 2025 20:25
@skyace65 skyace65 merged commit 01c2c9f into godotengine:master Feb 1, 2025
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Feb 1, 2025

Thanks!

@markdibarry markdibarry deleted the parallax2d-getting-started branch February 8, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 enhancement topic:2d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallax2d and "2d Parallax" tutorial pages do not explain how to set up the nodes
4 participants