Document $GODOT_SPLASH_CLASSES placeholder for custom HTML5 shells #10515
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
approved these changes
Jan 29, 2025
|
Thanks! And thanks a ton for documenting your engine PR, we really appreciate it when contributors do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the new placeholder introduced in godotengine/godot#99296, which allows adding CSS classes in custom HTML5 shells to reflect the
application/boot_splash/show_image,application/boot_splash/fullsizeandapplication/boot_splash/use_filtersettings.Please let me know if I can further improve the phrasing to make it more understandable.