Change the way the mobs are cleared from screen #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The existing behavior is better. It lets you see the enemies after death. Deleting everything on game over is jarring, and leaves the player wondering what happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created because of #10655
I think it makes more sense to free the mobs when it's game over so it's more visual to the person who is learning.
At this point in the tutorial when we die we have a ~2 second window to be able to start the game again. In this time all the mobs on the screen are not visible anymore, so the
queue_freeaction is not too obvious.It feels better to be able to see what this line of code is doing by removing them immediately when it's game over, this way we can visually see what the code is doing.
Before:
After:
