Build javascript target on windows host #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NicholasShatokhin Does this fix an existing open issue? If so, please link to it 🙂 |
Where can I find that issue? I just tried to compile library for my needs and found that it can not be done in windows terminal. |
If you didn't create one, nowhere, I guess 😛 I thought this pull request fixed an existing open issue (specifically #736). From a project management perspective, we try to keep links between issues and pull requests as visible as possible (so fixed issues don't remain open for no good reason). |
Faless
approved these changes
May 4, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build javascript target in windows command line, the arguments will not be in POSIX style which is needed for Emscripten. I fixed it