Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref<T>
now usesObject::cast_to
, which should be safer. The previous cast could cause undefined behavior if the types were incompatible, now it should return null, which can be checked with.is_valid()
oris_null()
.I also attempted to add a
static_assert
to enforceT
to derive fromReference
, however this would force any mention ofRef<T>
to also#include
the definition ofT
, which might not be desirable when forward-declarations are used to speed up compilation (as bindings are currently generated), so I haven't included it.Should fix #76