CMake: Rename all GODOT_ to GODOTCPP_ #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally, I think your reasoning for switching to And, if we're going to do it, doing it before the 4.4 release is the best time, because developers will already have to adapt to all the other cmake related changes. I'd be less inclined to make the change later, where we'd be forcing developers to update their cmake configuration right after we just made them do that. |
dsnopek
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Thanks! Unless anyone objects in the next ~24 hours, I think we should go for this.
However, this is missing updates in the doc/cmake.rst to show the renamed variables. If you have a chance to add that before it's merged, that'd be great, otherwise I can add that myself too.
This is for discussion primarily at this stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for discussion primarily at this stage.
While I've been working on other random projects, it comes up that they have their projects setup to build godot so that they can debug the editor and their gdextension at the same time.
This does create a sort of name clash where it ends up feeling confusing that the variables used
GODOT_are for the bindings, and not for the engine.So I'm just putting this out there, to see what others thoughts are.