Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Allow selecting Godot version to run the tests with #1494

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[4.2] Allow selecting Godot version to run the tests with #1494

merged 1 commit into from
Jun 14, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jun 14, 2024

This is the Godot 4.2 version of PR #1493

This will also be cherry-picked (with a version change) to the 4.1 branch

@dsnopek dsnopek added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.1 labels Jun 14, 2024
@dsnopek dsnopek requested a review from a team as a code owner June 14, 2024 16:25
@dsnopek dsnopek changed the title [4.2] Allow selecting Godot version to run the tests with [DRAFT] [4.2] Allow selecting Godot version to run the tests with Jun 14, 2024
@dsnopek dsnopek marked this pull request as draft June 14, 2024 16:26
@dsnopek dsnopek marked this pull request as ready for review June 14, 2024 16:39
@dsnopek dsnopek changed the title [DRAFT] [4.2] Allow selecting Godot version to run the tests with [4.2] Allow selecting Godot version to run the tests with Jun 14, 2024
AThousandShips
AThousandShips approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the tests, and I think this is at least a good temporary solution until we decide more specifically what to do in order to ensure it all works

@dsnopek dsnopek mentioned this pull request Jun 14, 2024
Merged
@dsnopek
Copy link
Collaborator Author

dsnopek commented Jun 14, 2024

Cherry-picking for 4.1 in PR #1491

@dsnopek dsnopek merged commit 7e72c8b into godotengine:4.2 Jun 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsnopek @AThousandShips