Adjusting GDCLASS macro to modern C++ clang-tidy checks #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -238,7 +243,7 @@ public: | |||
| static void notification_bind(GDExtensionClassInstancePtr p_instance, int32_t p_what, GDExtensionBool p_reversed) { \ | |||
| if (p_instance && m_class::_get_notification()) { \ | |||
| if (m_class::_get_notification() != m_inherits::_get_notification()) { \ | |||
| m_class *cls = reinterpret_cast<m_class *>(p_instance); \ | |||
| auto cls = reinterpret_cast<m_class *>(p_instance); \ | |||
There was a problem hiding this comment.
auto is not allowed
That should apply here as well, no reason to use it here
|
Ok, then I need to some workaround to disable clang-tidy check for that part. |
|
You should always adapt your the use of your tool to fit the codebase, not the other way around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
autoto avoid type repetition.Why
Using
GDCLASSis not treated by clang-tidy as usage of system header resource, because it is macro, so it perform checks on it. To make possible pass code inspection by clang-tidy checks (modernize-use-autoandcppcoreguidelines-special-member-functions) given change are needed.