Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCons] Merge OSXCross tools into platform ones #1191

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[SCons] Merge OSXCross tools into platform ones #1191

merged 1 commit into from
Jul 31, 2023

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Jul 23, 2023

As discussed in #1188

@Faless Faless added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jul 23, 2023
@Faless Faless requested a review from a team as a code owner July 23, 2023 20:46
@Faless Faless force-pushed the build/unify_osxcross branch from a7c6fe6 to 6d19513 Compare July 23, 2023 20:54
adamscott
adamscott approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job refactoring the tools.

@adamscott adamscott changed the title [SCons] Merge OSXCross tools into platofrm ones [SCons] Merge OSXCross tools into platform ones Jul 24, 2023
dsnopek
dsnopek approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The code looks good to me. Unfortunately, I don't have osxcross setup to do a real test build, but skimming the code, all the bits seem to be copy-pasted faithfully :-)

@dsnopek dsnopek merged commit 845226d into godotengine:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faless @dsnopek @adamscott