Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Handle new template names and dlink_enabled=yes #67

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

akien-mga
Copy link
Member

Follow-up to godotengine/godot#65094.

Also reverts LTO change from #62, we found that while it's much slower to link, full LTO still produces smaller binaries and that's quite important for the Web platform.

Copy link
Contributor

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Follow-up to godotengine/godot#65094.

Also reverts LTO change from #62, we found that while it's much slower
to link, full LTO still produces smaller binaries and that's quite
important for the Web platform.
@akien-mga akien-mga force-pushed the web-templates-rename branch from dc8c00c to 0bd0362 Compare September 7, 2022 08:28
@akien-mga
Copy link
Member Author

Tested, build-release.sh was missing the .wasm32 arch suffix. Now it's working fine.

@akien-mga akien-mga merged commit 9aa0cb9 into main Sep 7, 2022
@akien-mga akien-mga deleted the web-templates-rename branch September 7, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants