Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated GDNative API checks which prevented compilation of Godot 3.5 RC #909

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Remove outdated GDNative API checks which prevented compilation of Godot 3.5 RC #909

merged 1 commit into from
Jul 17, 2022

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Jul 17, 2022 •
edited
Loading

Fixes #904.

This supersedes the check originally discussed in #396.

@Bromeon Bromeon added bug c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem labels Jul 17, 2022
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build succeeded:

@bors bors bot merged commit 626648b into godot-rust:master Jul 17, 2022
@Bromeon Bromeon deleted the bugfix/gdnative-api-checks branch July 17, 2022 08:30
@Bromeon Bromeon mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GDNative 1.3 version check breaks compilation for Godot 3.5 RC
1 participant
@Bromeon