Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#396: panic for api v1.3 (Godot 4) #476

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

halzy
Copy link
Member

@halzy halzy commented Jun 26, 2020

No description provided.

@ghost
Copy link

ghost commented Jun 26, 2020

I think we should check for this at runtime as well? Also there should be a check for the API struct type (CORE).

@halzy halzy force-pushed the halzy/396-godot4-panic branch from 994dfab to 3e69d97 Compare June 30, 2020 15:44
@halzy
Copy link
Member Author

halzy commented Jun 30, 2020

I think we should check for this at runtime as well? Also there should be a check for the API struct type (CORE).

Updated to test at runtime. Uses report_init_error() when bailing.
Also checked it by modifying modules/gdnative/gdnative_api.json in Godot code and loading the hello_world example.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 30, 2020

Build succeeded:

@bors bors bot merged commit 5e6bac4 into godot-rust:master Jun 30, 2020
@halzy halzy deleted the halzy/396-godot4-panic branch June 30, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant